Probably a problem with the sd card. Pull the battery. Remove the card. Reboot the phone. Try taking a pic without the card. If it still doesn't work, there is a problem with the camera. If you can take a pic, then the card may be bad or it may have some corrupt files. Try reformatting the card before you trash it.
Posted from my CrackBerry at wapforums.crackberry.com